On 18.11.2021 16:14, Jean Delvare wrote:
> On Thu, 18 Nov 2021 16:03:39 +0200, Jarkko Nikula wrote:
>> On 11/18/21 12:09 PM, Jean Delvare wrote:
>>> On Mon, 08 Nov 2021 21:10:12 +0100, Heiner Kallweit wrote:
>>>> +#define DEF_FEATURES (FEATURE_BLOCK_PROC | FEATURE_I2C_BLOCK_READ | \
>>>
>>> Not a good name ("default" isn't descriptive) and not consistent
>>> either. I suggest "FEATURES_82801EB" instead, as this is the first
>>> chipset which supported all these features. And you can make the
>>> definitions of FEATURES_82801DB and FEATURES_82801EB consistent
>>> (spacing/alignment).
>>>
>> How about calling default as FEATURES_ICH5 and 82801DB as FEATURES_ICH4?
>> That makes easier to follow comments like "/* ICH4 and later */" in the
>> code.
>
> Good idea :-)
>
Thanks for the reviews. Then I'll incorporate the remarks and send a v2.
