On 10/11/2021 14:58, Geert Uytterhoeven wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Conor, > >>>> plic: interrupt-controller@c000000 { >>>> - #interrupt-cells = <1>; >>>> - compatible = "sifive,fu540-c000-plic", "sifive,plic-1.0.0"; >>>> + compatible = "sifive,plic-1.0.0"; >>> >>> Why drop the first one again? >> we felt it didnt make sense to have something that specifically >> references the fu540 in the device tree for this board. > > That would be a revert of commit 73d3c44115514616 ("riscv: dts: > microchip: add missing compatibles for clint and plic"), which you > supplied an R-b tag for? > > Is this the same plic as in the FU540 SoC? Or do we need a new > microchip,mpfs-plic compatible value? > yeah, ignore that. i confused this change (which is an accidental clobber) with another sifive compatible that was dropped for not being relevant. hardly makes sense to drop this one when i kept it for the clint and cache controller! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >