On 2021-10-26 22:29, Rob Herring wrote: > On Wed, Oct 13, 2021 at 04:10:02PM +0200, Horatiu Vultur wrote: >> Add optional property 'select-delay' DT property. In case this is set >> then a delay is added when changing mux state. The value is specified in >> usec. >> >> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/i2c/i2c-mux-gpio.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.txt >> index d4cf10582a26..d0dacbad491a 100644 >> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.txt >> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-gpio.txt >> @@ -28,6 +28,7 @@ Required properties: >> Optional properties: >> - idle-state: value to set the muxer to when idle. When no value is >> given, it defaults to the last value used. >> +- select-delay: GPIO settle delay when changing mux state. In usec. > > Seems generally useful. Can we add this first to the mux control > binding, then use it here (or better yet, use the mux binding if you > can instead) I do not think that adding a delay to the mux-control binding is what we want. Any change to the mux-control will be quick. What may take time is rearranging the routing inside the mux and for the muxed signals affected by those changes to then settle. This might sound like splitting hairs, but the distinction does provide a hint for where the delay fits best. And I think that any user of a mux-control that might need a delay after changed mux state knows best what that delay really is. Considering the case where a single mux-control is used for two different muxes that are routing signals with different settling time requirements. Why should a quick path suffer the delays enforced for some other, slow, path? So, I don't think the delay fits as a property of the mux-control. > Also, properties with units need a standard unit suffix. Another naming issue is that the io-channel-mux binding recently added a settle-time-us property for this exact purpose, it might be good to follow that lead. However, since I'm not really happy with the implementation, it might be easier to instead use a generic mux-control and extend the i2c-mux-gpmux driver with this settling time. See comments on patch 2/2 for details. Cheers, Peter >> >> For each i2c child node, an I2C child bus will be created. They will >> be numbered based on their order in the device tree. >> -- >> 2.33.0 >>
