On Sun, Sep 26, 2021 at 12:00 PM Sven Peter <sven@xxxxxxxxxxxxx> wrote: > > In preparation for splitting this driver up into a platform_driver > and a pci_driver, replace outl/inl usage with ioport_map and > ioread32/iowrite32. > > Signed-off-by: Sven Peter <sven@xxxxxxxxxxxxx> > > + smbus->ioaddr = ioport_map(smbus->base, smbus->size); > + if (!smbus->ioaddr) { > + error = -EBUSY; > + goto out_release_region; > + } While this works, I would suggest using the more regular pci_iomap() or pcim_iomap() helper to turn the port number into an __iomem token. Arnd