Re: [PATCH v2 2/2] i2c: synquacer: fix deferred probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 12 Aug 2021 at 22:39, Sergey Shtylyov <s.shtylyov@xxxxxx> wrote:
>
> The driver overrides the error codes returned by platform_get_irq() to
> -ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe
> permanently instead of the deferred probing. Switch to propagating the
> error codes upstream...
>
> Fixes: 0d676a6c4390 ("i2c: add support for Socionext SynQuacer I2C controller")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx>

Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>

>
> ---
>  drivers/i2c/busses/i2c-synquacer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/i2c/busses/i2c-synquacer.c
> ===================================================================
> --- linux.orig/drivers/i2c/busses/i2c-synquacer.c
> +++ linux/drivers/i2c/busses/i2c-synquacer.c
> @@ -578,7 +578,7 @@ static int synquacer_i2c_probe(struct pl
>
>         i2c->irq = platform_get_irq(pdev, 0);
>         if (i2c->irq < 0)
> -               return -ENODEV;
> +               return i2c->irq;
>
>         ret = devm_request_irq(&pdev->dev, i2c->irq, synquacer_i2c_isr,
>                                0, dev_name(&pdev->dev), i2c);



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux