On Mon, Jul 5, 2021 at 11:03 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > On 05-07-21, 14:53, Jie Deng wrote: > > +#include <linux/types.h> > > +#include <linux/const.h> > > Both of these need to be the uapi headers as Andy said earlier They are already since this header _is_ UAPI, what you are suggesting is gonna not work, although it's correct for in-kernel users of UAPI headers. > and they better > be in alphabetical order. I prefer that as well. > #include <uapi/linux/const.h> > #include <uapi/linux/types.h> -- With Best Regards, Andy Shevchenko