Re: [PATCH] i2c: ali1535: mention that the device should not be disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 25 Jun 2021 17:17:58 +0200, Wolfram Sang wrote:
> The comment from the i801 driver is valid here, too, so copy it.
> 
> Reported-by: Jean Delvare <jdelvare@xxxxxxx>
> Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-ali1535.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
> index fb93152845f4..ee83c4581bce 100644
> --- a/drivers/i2c/busses/i2c-ali1535.c
> +++ b/drivers/i2c/busses/i2c-ali1535.c
> @@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev)
>  {
>  	i2c_del_adapter(&ali1535_adapter);
>  	release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
> +
> +	/*
> +	 * do not call pci_disable_device(dev) since it can cause hard hangs on
> +	 * some systems during power-off
> +	 */
>  }
>  
>  static struct pci_driver ali1535_driver = {

Can't hurt.

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

-- 
Jean Delvare
SUSE L3 Support



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux