Hi Andy, On Wed, 16 Jun 2021 17:04:41 +0300, Andy Shevchenko wrote: > Switch to use module_parport_driver() to reduce boilerplate code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/i2c/busses/i2c-parport.c | 36 ++++++++++---------------------- > 1 file changed, 11 insertions(+), 25 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-parport.c b/drivers/i2c/busses/i2c-parport.c > index a535889acca6..ccbbc9306e88 100644 > --- a/drivers/i2c/busses/i2c-parport.c > +++ b/drivers/i2c/busses/i2c-parport.c > @@ -267,6 +267,16 @@ static void i2c_parport_attach(struct parport *port) ^^^^ > int i; > struct pardev_cb i2c_parport_cb; > > + if (type < 0) { > + pr_warn("adapter type unspecified\n"); > + return -ENODEV; ^^^^^^^ > + } Does not build. -- Jean Delvare SUSE L3 Support