Hi Phillip,
On Tue, Jun 15, 2021 at 9:49 AM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> On Mon, 2021-06-14 at 20:32 +0100, Biju Das wrote:
> > RZ/G2L i2c controller is compatible with RZ/A i2c controller.
> > By default IP is in reset state, so need to perform release
> > reset before accessing any register.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> > v1->v2
> > * Changed to devm_reset_control_get_exclusive API for reset_control_get.
> > * Updated KCONFIG to enable RESET_CONTROLLER only if it is RZ/G2L SoC.
> > * Filled .data for RIIC_RZ_A.
>
> Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
>
> > ---
> > drivers/i2c/busses/Kconfig | 1 +
> > drivers/i2c/busses/i2c-riic.c | 23 ++++++++++++++++++++++-
> > 2 files changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index 281a65d9b44b..17bd15ad8761 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -941,6 +941,7 @@ config I2C_QUP
> > config I2C_RIIC
> > tristate "Renesas RIIC adapter"
> > depends on ARCH_RENESAS || COMPILE_TEST
> > + select RESET_CONTROLLER if ARCH_R9A07G044
>
> I would have expected the select RESET_CONTROLLER to be placed under
> config ARCH_R9A07G044. Since this is a pretty architecture specific
> driver, I'm ok with this as well.
My first thought was "that would enable it unconditionally on
ARCH_R9A07G044, even when RIIC is not used", but then I realized
there's already a "select RESET_CONTROLLER" for CLK_RZG2L (in
linux-next). So the select for I2C_RIIC can indeed be dropped.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
