Hi Heiner, On Tue, 25 May 2021 21:59:05 +0200, Heiner Kallweit wrote: > Polling uses the same timeout as irq mode: 400 * 500us = 200ms = HZ / 5. > So let's use the adapter->timeout value also for polling. This has the > advantage that userspace can control the timeout value for polling as > well. In addition change the code to make it better readable. > Last but not least remove the timeout debug messages. Calls to both > functions are followed by a call to i801_check_post() that will print > an error message in case of timeout. I think that the intent was to differentiate between regular polling and BYTE_DONE polling. But I agree it's not really important, as the caller probably already knows which type of transaction failed (simple or block). > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > --- > drivers/i2c/busses/i2c-i801.c | 36 +++++++++++++---------------------- > 1 file changed, 13 insertions(+), 23 deletions(-) > (...) Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> Tested-by: Jean Delvare <jdelvare@xxxxxxx> -- Jean Delvare SUSE L3 Support
