On 06/06/2021 22.55, Heiner Kallweit wrote:
As explained in [0] currently we may leave SMBHSTSTS_INUSE_STS set, thus potentially breaking ACPI/BIOS usage of the SMBUS device. Seems patch [0] needs a little bit more of review effort, therefore I'd suggest to apply a part of it as quick win. Just clearing SMBHSTSTS_INUSE_STS when leaving i801_access() should fix the referenced issue and leaves more time for discussing a more sophisticated locking handling.
out: + /* Unlock the SMBus device for use by BIOS/ACPI */ + outb_p(SMBHSTSTS_INUSE_STS, SMBHSTSTS(priv)); + pm_runtime_mark_last_busy(&priv->pci_dev->dev);
Yup, I was thinking of suggesting just this part if the rest of the patch were deemed more controversial. Thanks :)
Reviewed-by: Hector Martin <marcan@xxxxxxxxx> -- Hector Martin (marcan@xxxxxxxxx) Public Key: https://mrcn.st/pub
