On Thu, 03 Jun 2021, Wolfram Sang wrote: > On Thu, May 20, 2021 at 08:00:58PM +0100, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'timing0' not described in 'mxs_i2c_dev' > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'timing1' not described in 'mxs_i2c_dev' > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'timing2' not described in 'mxs_i2c_dev' > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'dmach' not described in 'mxs_i2c_dev' > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'pio_data' not described in 'mxs_i2c_dev' > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'addr_data' not described in 'mxs_i2c_dev' > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'sg_io' not described in 'mxs_i2c_dev' > > drivers/i2c/busses/i2c-mxs.c:131: warning: Function parameter or member 'dma_read' not described in 'mxs_i2c_dev' > > Disabling kernel-doc works around, does not really fix, or? You're right. With cases of genuine oversight or a bit of doc-rot, I tend to help where I can. However issues such as these where documentation has been either severely neglected or half-arsed require either the author or another knowledgeable person so provide fix-ups in the way of additional quality descriptions. IMHO, we wouldn't want to foster the impression that it's okay to provide a non-determined effort, safe in the knowledge that someone will come along later and finish the job for them at a later date. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
