On 6/1/2021 7:32 PM, Chris Packham wrote:
>
> On 2/06/21 9:03 am, Ray Jui wrote:
>>
>> On 5/30/2021 3:56 PM, Chris Packham wrote:
>>> From: Richard Laing <richard.laing@xxxxxxxxxxxxxxxxxxx>
>>>
>>> The bcm-iproc controller can put the SDA/SCL lines into bit-bang mode,
>>> make use of this to support i2c bus recovery.
>>>
>>> Signed-off-by: Richard Laing <richard.laing@xxxxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
>>> ---
> <snip>
>> +
>>> +static struct i2c_bus_recovery_info bcm_iproc_recovery_info = {
>> static const struct ...
>
> The kernel test bot doesn't like the suggestion.
>
> >> drivers/i2c/busses/i2c-bcm-iproc.c:1264:26: error: assigning to
> 'struct i2c_bus_recovery_info *' from 'const struct
> i2c_bus_recovery_info *' discards qualifiers
> [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
>
> adap->bus_recovery_info = &bcm_iproc_recovery_info;
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~
>
> I can see why. Are you happy for me to drop the const in v3? Or perhaps
> you have a better suggestion.
>
Yeah of course. Please drop it. Sorry I missed that while making that
suggestion.
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
