Thanks for the fix. I was about to propose it ;) On Thu, May 20, 2021 at 08:01:02PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/busses/i2c-st.c:531: warning: expecting prototype for st_i2c_handle_write(). Prototype was for st_i2c_handle_read() instead > drivers/i2c/busses/i2c-st.c:566: warning: expecting prototype for st_i2c_isr(). Prototype was for st_i2c_isr_thread() instead > > Cc: Patrice Chotard <patrice.chotard@xxxxxxxxxxx> > Cc: Maxime Coquelin <maxime.coquelin@xxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-i2c@xxxxxxxxxxxxxxx > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > --- > drivers/i2c/busses/i2c-st.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c > index faa81a95551fe..30089b38044b5 100644 > --- a/drivers/i2c/busses/i2c-st.c > +++ b/drivers/i2c/busses/i2c-st.c > @@ -524,7 +524,7 @@ static void st_i2c_handle_write(struct st_i2c_dev *i2c_dev) > } > > /** > - * st_i2c_handle_write() - Handle FIFO enmpty interrupt in case of read > + * st_i2c_handle_read() - Handle FIFO enmpty interrupt in case of read Could you also fix the typo enmpty -> empty at the same time ? > * @i2c_dev: Controller's private data > */ > static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > @@ -558,7 +558,7 @@ static void st_i2c_handle_read(struct st_i2c_dev *i2c_dev) > } > > /** > - * st_i2c_isr() - Interrupt routine > + * st_i2c_isr_thread() - Interrupt routine > * @irq: interrupt number > * @data: Controller's private data > */ > -- > 2.31.1 > Regards, Alain
