On Tue, 11 May 2021, Michael Zaidman wrote: > Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver") > > The ft260_hid_feature_report_get() checks if the return size matches > the requested size. But the function can also fail with at least -ENOMEM. > Add the < 0 checks. > > In ft260_hid_feature_report_get(), do not do the memcpy to the caller's > buffer if there is an error. > > --- > v4 Fixed commit message > --- > v3 Simplify and optimize the changes > --- > v2: add unlikely()'s for error conditions > --- > > Signed-off-by: Tom Rix <trix@xxxxxxxxxx> > Signed-off-by: Michael Zaidman <michael.zaidman@xxxxxxxxx> Who should be the author of the git commit? Thanks, -- Jiri Kosina SUSE Labs