On 2021/4/15 16:18, Yicong Yang wrote: > On 2021/4/15 2:06, Geert Uytterhoeven wrote: >> Hi Yicong, >> >> On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang <yangyicong@xxxxxxxxxxxxx> wrote: >>> On 2021/4/13 20:26, Geert Uytterhoeven wrote: >>>> The HiSilicon Kunpeng I2C controller is only present on HiSilicon >>>> Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. >>>> Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user >>>> about this driver when configuring a kernel without Hisilicon platform >>>> or ACPI firmware support. >>> >>> this is a public IP which doesn't specifically depend on ARCH_HISI. I'm >>> not sure all the platform this IP on has ARCH_HISI configured. The driver >>> will not be compiled by default config. This is not correct to have >>> this dependence. >> >> Thanks for your answer! >> >> I guess it's still fine to add a dependency on ACPI? > > yes. currently we only use this driver through ACPI. So at least > for this driver, it make sense to keep the dependency. > sorry. i was a little mess about this. I dropped this in [1]. so just keep it as is. [1] https://lore.kernel.org/linux-i2c/YGMntYT2iz72wgrd@xxxxxxxxxxxxxxxxxx/ >> >> Thanks again! >> >>>> Fixes: d62fbdb99a85730a ("i2c: add support for HiSilicon I2C controller") >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >>>> --- >>>> drivers/i2c/busses/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >>>> index b5b4e0d0ff4dd0bc..3ead6d9e130b2ebc 100644 >>>> --- a/drivers/i2c/busses/Kconfig >>>> +++ b/drivers/i2c/busses/Kconfig >>>> @@ -647,7 +647,7 @@ config I2C_HIGHLANDER >>>> >>>> config I2C_HISI >>>> tristate "HiSilicon I2C controller" >>>> - depends on ARM64 || COMPILE_TEST >>>> + depends on (ARM64 && ARCH_HISI && ACPI) || COMPILE_TEST >>>> help >>>> Say Y here if you want to have Hisilicon I2C controller support >>>> available on the Kunpeng Server. >> \ >> Gr{oetje,eeting}s, >> >> Geert >> > > > . >
