On Thu, Sep 3, 2020 at 4:48 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote: > 03.09.2020 14:17, Andy Shevchenko пишет: > > On Thu, Sep 3, 2020 at 3:54 AM Dmitry Osipenko <digetx@xxxxxxxxx> wrote: ... > >> + of_property_read_u32(np, "clock-frequency", &bus_clk_rate); > >> + i2c_dev->bus_clk_rate = bus_clk_rate; > > > > Hmm... I dunno if Wolfram is going to implement a special helper > > exactly for this. I remember we discussed that with him during v5.8 > > (?) times. > > I now see that there is a i2c_parse_fw_timings() which parses > "clock-frequency" and other common properties. I could switch to use > that helper, but not sure whether it would be really worthwhile because > only one property is needed to be parsed. I'll consider this change for > v4, thank you for the suggestion! That's exactly why I was wondering about the current state of affairs with the discussed helper which should only parse the clock-frequency property. -- With Best Regards, Andy Shevchenko