On Tue, Sep 1, 2020 at 11:48 AM Wolfram Sang <wsa@xxxxxxxxxx> wrote:
> > > +/**
> > > + * struct i2c_bus_settings - The configured i2c bus settings
> > > + * @mode: Configured i2c bus mode (PCA9665)
> > > + * @tlow: Configured SCL LOW period (PCA9665)
> > > + * @thi: Configured SCL HIGH period (PCA9665)
> > > + * @clock_freq: The configured clock frequency (PCA9564)
> > > + */
> > > +struct i2c_bus_settings {
> > > + int mode;
> > > + int tlow;
> > > + int thi;
> > > + int clock_freq;
> > > +};
> >
> > This is a good candidate to have it in generic header for sake of the
> > unification. Possible users:
> >
> > struct tegra_i2c_hw_feature
> > struct cci_data::struct hw_params
>
> Could be evaluated, but outside the scope of this patch, I think. This
> is a bugfix, so a self-contained patch makes backporting a lot easier.
True, my point here is to think if we were beneficial of this
definition in the i2c.h.
--
With Best Regards,
Andy Shevchenko
