Re: [PATCH 2/2] decode-vaio: Add support for the at24 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 Aug 2020 10:47:03 +0200, Wolfram Sang wrote:
> > -for (my $i = 0, $found=0; $i <= 4 && !$found; $i++)
> > +for (my $i = 0, $found=0; $i <= 31 && !$found; $i++)  
> 
> Isn't this an unrelated change, scanning more busses? Should be at least
> mentioned in the commit message, if so.

You're right, it should be a separate commit. I had to do this to be
able to test my changes with i2c-stub instead of using the actual old
Sony laptop. Then I forgot the change was there. I'll push that change
anyway as it can't hurt and everything that makes testing easier is
welcome.

Thanks,
-- 
Jean Delvare
SUSE L3 Support



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux