On Sat, Jul 25, 2020 at 04:07:36PM +0200, Wolfram Sang wrote:
> All i2c_new_device-alike functions return ERR_PTR these days, but this
> fallback function was missed.
I think either will work.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks!
> Fixes: 2dea645ffc21 ("i2c: acpi: Return error pointers from i2c_acpi_new_device()")
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> I recall that -ENOSYS is returned in case something is not compiled in.
> I am open for -ENODEV if this is deemed better...
>
> include/linux/i2c.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index b8b8963f8bb9..83fe48304781 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -1001,7 +1001,7 @@ static inline u32 i2c_acpi_find_bus_speed(struct device *dev)
> static inline struct i2c_client *i2c_acpi_new_device(struct device *dev,
> int index, struct i2c_board_info *info)
> {
> - return NULL;
> + return ERR_PTR(-ENOSYS);
> }
> static inline struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle)
> {
> --
> 2.27.0
>
--
With Best Regards,
Andy Shevchenko
