23.07.2020 15:18, Krishna Yarlagadda пишет:
> Enable GPC DMA support for Tegra186 and Tegra194
>
> Signed-off-by: Rajesh Gumasta <rgumasta@xxxxxxxxxx>
> Signed-off-by: Krishna Yarlagadda <kyarlagadda@xxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-tegra.c | 25 ++++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 8ab968e..77198fc 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -236,6 +236,7 @@ struct tegra_i2c_hw_feature {
> u32 setup_hold_time_hs_mode;
> bool has_interface_timing_reg;
> bool has_slcg_support;
> + bool has_gpc_dma;
> };
>
> /**
> @@ -432,11 +433,18 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
> dma_addr_t dma_phys;
> int err;
>
> - if (!i2c_dev->hw->has_apb_dma)
> - return 0;
> -
> - if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
> - dev_dbg(i2c_dev->dev, "Support for APB DMA not enabled!\n");
> + if (i2c_dev->hw->has_gpc_dma) {
> + if (!IS_ENABLED(CONFIG_TEGRA_GPC_DMA)) {
Single line, please.
> + dev_dbg(i2c_dev->dev, "Support for GPC DMA not enabled!\n");
> + return 0;
> + }
> + } else if (i2c_dev->hw->has_apb_dma) {
> + if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
Here too.
> + dev_dbg(i2c_dev->dev, "Support for APB DMA not enabled!\n");
> + return 0;
> + }
> + } else {
> + dev_dbg(i2c_dev->dev, "DMA is not enabled!\n");
Also, please drop all the exclamation marks.
