Hi Jarrko, On Wed, 10 Jun 2020 17:11:42 +0300, Jarkko Nikula wrote: > Modules with multiple authors should use multiple MODULE_AUTHOR() > statements. Split the i2c modules with multiple authors to use multiple > MODULE_AUTHOR() statements. Out of curiosity, is this documented anywhere, and what is the rationale? FWIW, this change slightly increases the binary size of the modules. > Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > --- > I decided to change all these modules in one patch. I can split if needed. > --- > drivers/i2c/algos/i2c-algo-pca.c | 4 ++-- > drivers/i2c/busses/i2c-ali1535.c | 8 ++++---- > drivers/i2c/busses/i2c-ali15x3.c | 6 +++--- > drivers/i2c/busses/i2c-emev2.c | 3 ++- > drivers/i2c/busses/i2c-i801.c | 3 ++- > drivers/i2c/busses/i2c-piix4.c | 4 ++-- > drivers/i2c/busses/i2c-pnx.c | 3 ++- > drivers/i2c/busses/i2c-sh_mobile.c | 3 ++- > drivers/i2c/busses/i2c-sibyte.c | 3 ++- > drivers/i2c/i2c-dev.c | 4 ++-- > 10 files changed, 23 insertions(+), 18 deletions(-) > (...) If that's the way we are going then the patch looks good. Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> However I see multi-author MODULE_AUTHOR() statements left in i2c-nomadik.c, i2c-sirf.c and i2c-viapro.c, any reason why these are not included in your patch? -- Jean Delvare SUSE L3 Support
