On Wed, May 27, 2020 at 07:05:44PM +0300, Andy Shevchenko wrote:
> On Wed, May 27, 2020 at 06:30:46PM +0300, Serge Semin wrote:
> > Baikal-T1 System Controller is equipped with a dedicated I2C Controller
> > which functionality is based on the DW APB I2C IP-core, the only
> > difference in a way it' registers are accessed. There are three access
> > register provided in the System Controller registers map, which indirectly
> > address the normal DW APB I2C registers space. So in order to have the
> > Baikal-T1 System I2C Controller supported by the common DW APB I2C driver
> > we created a dedicated Dw I2C controller model quirk, which retrieves the
> > syscon regmap from the parental dt node and creates a new regmap based on
> > it.
>
> ...
>
> > +static struct regmap_config bt1_i2c_cfg = {
> > + .reg_bits = 32,
> > + .val_bits = 32,
> > + .reg_stride = 4,
> > + .fast_io = true,
> > + .reg_read = bt1_i2c_read,
> > + .reg_write = bt1_i2c_write,
>
> > + .max_register = DW_IC_COMP_TYPE
>
> Perhaps leave comma here.
If v6 is required, I'll fix it there.
-Sergey
>
> > +};
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
