On Tue, May 12, 2020 at 06:12:32PM +0300, Jarkko Nikula wrote: > On 5/11/20 4:42 PM, Andy Shevchenko wrote: > > On Mon, May 11, 2020 at 04:11:57PM +0300, Jarkko Nikula wrote: > > > On 5/7/20 4:51 PM, Andy Shevchenko wrote: > > > > In order to export array supported speed for wider use, > > > > split out them along with i2c_dw_validate_speed() helper. ... > > > This header is included by every i2c-designware-*.c file and this inline > > > function is not tiny. Would it be better to have this in > > > i2c-designware-common.c instead? > > > > Yes, but then we will need to export i2c_dw_supported_speeds as well as its > > array size. > > > Would that not be needed if you move ACPI parts also into > i2c-designware-common.c? Yes, in the intermediate patch. I'm about to send v2, where you may see how it looks like. -- With Best Regards, Andy Shevchenko