On Mon, May 11, 2020 at 09:59:15PM +0200, Wolfram Sang wrote: > On Wed, May 06, 2020 at 10:29:12AM +0100, Russell King wrote: > > Most of i2c_pxa_pio_xfer() and i2c_pxa_xfer() are identical; the only > > differences are that i2c_pxa_pio_xfer() may reset the bus, and they > > use different underlying transfer functions. The retry loop is the > > same. Consolidate these two functions. > > > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > > Fails to build here: > > In file included from ./include/linux/device.h:15, > from ./include/linux/acpi.h:15, > from ./include/linux/i2c.h:13, > from drivers/i2c/busses/i2c-pxa.c:23: > drivers/i2c/busses/i2c-pxa.c: In function ‘i2c_pxa_internal_xfer’: > drivers/i2c/busses/i2c-pxa.c:1118:13: error: ‘adap’ undeclared (first use in this function); did you mean ‘vmap’? > dev_dbg(&adap->dev, "Retrying transmission\n"); > I'll take a look at it - it's likely that some changes got missed while keeping all these patches on top of several different trees. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
