On 5/7/20 4:51 PM, Andy Shevchenko wrote:
For better maintenance and possible code reuse in the future,
split out ACPI parts into a separate module.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/i2c/busses/Makefile | 3 +
drivers/i2c/busses/i2c-designware-acpi.c | 130 +++++++++++++++++
drivers/i2c/busses/i2c-designware-core.h | 8 ++
drivers/i2c/busses/i2c-designware-platdrv.c | 151 +++-----------------
4 files changed, 163 insertions(+), 129 deletions(-)
create mode 100644 drivers/i2c/busses/i2c-designware-acpi.c
Comment to both of this and patch 2/4:
I'm not so fan of introducing even more i2c-designware modules. No any
other drivers have so many files as i2c-designware in
drivers/i2c/busses/*.c. Feeling a bit of hall of shame because of it :-)
What's the rationale here? Currently i2c-designware-platdrv.c is 512
lines of code so it's not too hard to maintain in my opinion.
--
Jarkko
