Re: [PATCH 1/1] i2c: Add i2c-pseudo driver for userspace I2C adapters.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v5.7-rc4 next-20200508]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Matthew-Blecker/i2c-Add-i2c-pseudo-driver-for-userspace-I2C-adapters/20200509-011221
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: um-allmodconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/i2c/i2c-pseudo.c:1855:15: error: initializer element is not constant
      .cmd_size = strlen(I2CP_MXFER_REPLY_CMD),
                  ^~~~~~
   drivers/i2c/i2c-pseudo.c:1855:15: note: (near initialization for 'i2cp_cmds[0].cmd_size')
   drivers/i2c/i2c-pseudo.c:1865:15: error: initializer element is not constant
      .cmd_size = strlen(I2CP_ADAP_START_CMD),
                  ^~~~~~
   drivers/i2c/i2c-pseudo.c:1865:15: note: (near initialization for 'i2cp_cmds[1].cmd_size')
   drivers/i2c/i2c-pseudo.c:1872:15: error: initializer element is not constant
      .cmd_size = strlen(I2CP_ADAP_SHUTDOWN_CMD),
                  ^~~~~~
   drivers/i2c/i2c-pseudo.c:1872:15: note: (near initialization for 'i2cp_cmds[2].cmd_size')
   drivers/i2c/i2c-pseudo.c:1879:15: error: initializer element is not constant
      .cmd_size = strlen(I2CP_GET_NUMBER_CMD),
                  ^~~~~~
   drivers/i2c/i2c-pseudo.c:1879:15: note: (near initialization for 'i2cp_cmds[3].cmd_size')
   drivers/i2c/i2c-pseudo.c:1886:15: error: initializer element is not constant
      .cmd_size = strlen(I2CP_GET_PSEUDO_ID_CMD),
                  ^~~~~~
   drivers/i2c/i2c-pseudo.c:1886:15: note: (near initialization for 'i2cp_cmds[4].cmd_size')
   drivers/i2c/i2c-pseudo.c:1893:15: error: initializer element is not constant
      .cmd_size = strlen(I2CP_SET_NAME_SUFFIX_CMD),
                  ^~~~~~
   drivers/i2c/i2c-pseudo.c:1893:15: note: (near initialization for 'i2cp_cmds[5].cmd_size')
   drivers/i2c/i2c-pseudo.c:1902:15: error: initializer element is not constant
      .cmd_size = strlen(I2CP_SET_TIMEOUT_CMD),
                  ^~~~~~
   drivers/i2c/i2c-pseudo.c:1902:15: note: (near initialization for 'i2cp_cmds[6].cmd_size')

vim +1855 drivers/i2c/i2c-pseudo.c

  1849	
  1850	/* Command names are matched in this order, so sort by expected frequency. */
  1851	/* All elements should be initialized in their I2CP_CMD_*_IDX position. */
  1852	static const struct i2cp_cmd i2cp_cmds[] = {
  1853		[I2CP_CMD_MXFER_REPLY_IDX] = {
  1854			.cmd_string = I2CP_MXFER_REPLY_CMD,
> 1855			.cmd_size = strlen(I2CP_MXFER_REPLY_CMD),
  1856			.data_creator = i2cp_cmd_mxfer_reply_data_creator,
  1857			.data_shutdown = i2cp_cmd_mxfer_reply_data_shutdown,
  1858			.data_destroyer = i2cp_cmd_mxfer_reply_data_destroyer,
  1859			.header_receiver = i2cp_cmd_mxfer_reply_header_receiver,
  1860			.data_receiver = i2cp_cmd_mxfer_reply_data_receiver,
  1861			.cmd_completer = i2cp_cmd_mxfer_reply_cmd_completer,
  1862		},
  1863		[I2CP_CMD_ADAP_START_IDX] = {
  1864			.cmd_string = I2CP_ADAP_START_CMD,
  1865			.cmd_size = strlen(I2CP_ADAP_START_CMD),
  1866			.header_receiver = i2cp_cmd_adap_start_header_receiver,
  1867			.data_receiver = i2cp_cmd_adap_start_data_receiver,
  1868			.cmd_completer = i2cp_cmd_adap_start_cmd_completer,
  1869		},
  1870		[I2CP_CMD_ADAP_SHUTDOWN_IDX] = {
  1871			.cmd_string = I2CP_ADAP_SHUTDOWN_CMD,
  1872			.cmd_size = strlen(I2CP_ADAP_SHUTDOWN_CMD),
  1873			.header_receiver = i2cp_cmd_adap_shutdown_header_receiver,
  1874			.data_receiver = i2cp_cmd_adap_shutdown_data_receiver,
  1875			.cmd_completer = i2cp_cmd_adap_shutdown_cmd_completer,
  1876		},
  1877		[I2CP_CMD_GET_NUMBER_IDX] = {
  1878			.cmd_string = I2CP_GET_NUMBER_CMD,
  1879			.cmd_size = strlen(I2CP_GET_NUMBER_CMD),
  1880			.header_receiver = i2cp_cmd_get_number_header_receiver,
  1881			.data_receiver = i2cp_cmd_get_number_data_receiver,
  1882			.cmd_completer = i2cp_cmd_get_number_cmd_completer,
  1883		},
  1884		[I2CP_CMD_GET_PSEUDO_ID_IDX] = {
  1885			.cmd_string = I2CP_GET_PSEUDO_ID_CMD,
  1886			.cmd_size = strlen(I2CP_GET_PSEUDO_ID_CMD),
  1887			.header_receiver = i2cp_cmd_get_pseudo_id_header_receiver,
  1888			.data_receiver = i2cp_cmd_get_pseudo_id_data_receiver,
  1889			.cmd_completer = i2cp_cmd_get_pseudo_id_cmd_completer,
  1890		},
  1891		[I2CP_CMD_SET_NAME_SUFFIX_IDX] = {
  1892			.cmd_string = I2CP_SET_NAME_SUFFIX_CMD,
  1893			.cmd_size = strlen(I2CP_SET_NAME_SUFFIX_CMD),
  1894			.data_creator = i2cp_cmd_set_name_suffix_data_creator,
  1895			.data_destroyer = i2cp_cmd_set_name_suffix_data_destroyer,
  1896			.header_receiver = i2cp_cmd_set_name_suffix_header_receiver,
  1897			.data_receiver = i2cp_cmd_set_name_suffix_data_receiver,
  1898			.cmd_completer = i2cp_cmd_set_name_suffix_cmd_completer,
  1899		},
  1900		[I2CP_CMD_SET_TIMEOUT_IDX] = {
  1901			.cmd_string = I2CP_SET_TIMEOUT_CMD,
  1902			.cmd_size = strlen(I2CP_SET_TIMEOUT_CMD),
  1903			.data_creator = i2cp_cmd_set_timeout_data_creator,
  1904			.data_destroyer = i2cp_cmd_set_timeout_data_destroyer,
  1905			.header_receiver = i2cp_cmd_set_timeout_header_receiver,
  1906			.data_receiver = i2cp_cmd_set_timeout_data_receiver,
  1907			.cmd_completer = i2cp_cmd_set_timeout_cmd_completer,
  1908		},
  1909	};
  1910	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux