> I did like this now: If device_property_read_string() returns a firmware > name, I use that, otherwise init to 0xFF. But if it returns a firmware name, > and for some reason I get an error when trying to load that firmware I will > not default to 0xFF, but rather fail the probe. The logic in that is that if > you actively supply a firmware name, you should not silently get 0xFF in > your eeprom. Does that sound good? Sounds perfect to me. > > Yes, that is my idea. You also need to replace checking for an of_node > > with some equivalent for device properties maybe, but that should be > > easy to find out. > > It appears to me that those kind of checks are done inside > device_property_read_string() so I can just remove them and only look at the > return value of that function. Even better! > I have a patch now working on 4.14, will run some tests on it and then try > to forward-port to latest kernel och see if it works there as well. Looking forward to it. I will look at it right away then!
Attachment:
signature.asc
Description: PGP signature
