On Sat, Feb 15, 2020 at 07:20:20AM +0100, Jean Delvare wrote: > Hi Wolfram, > > On Mon, 10 Feb 2020 18:29:25 +0100, Wolfram Sang wrote: > > Only few drivers use this call, so drivers and I2C core are converted at > > once with this patch. By simply using i2c_new_client_device() instead of > > i2c_new_device(), we easily can return an ERRPTR for this function as > > well. To make out of tree users aware that something changed, the > > function is renamed to i2c_install_smbus_alert(). > > I wouldn't bother renaming the function. Chances that there actually > are out-of-tree users of this function are pretty small, and if that is > the case, they can adjust their code easily in a way that is still > compatible with old kernels. Agreed, it is easy. But they need to *know* that they need to adjust. Build error makes it obvious. Otherwise, the code will compile and silently not work anymore, I am afraid.
Attachment:
signature.asc
Description: PGP signature
