Hi Kieran, On Tue, Jan 7, 2020 at 10:26 AM Kieran Bingham <kieran@xxxxxxxxxxxxxxx> wrote: > This looks reasonable to me, I see Laurent has a concern over the use of > a WARN to present a backtrace, but I think in this instance it will be > useful as it will facilitate identifying what code path provided the > incorrect address. Quoting GregKH: | We really do not want WARN_ON() anywhere, as that causes systems with | panic-on-warn to reboot. https://lore.kernel.org/lkml/20191121135743.GA552517@xxxxxxxxx/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds