Add a shared header to declare amd756_smbus that is used by two files, to remove the following sparse warning: drivers/i2c/busses/i2c-amd756.c:286:20: warning: symbol 'amd756_smbus' was not declared. Should it be static? Signed-off-by: Ben Dooks (Codethink) <ben.dooks@xxxxxxxxxxxxxxx> --- Cc: Jean Delvare <jdelvare@xxxxxxxx> Cc: linux-i2c@xxxxxxxxxxxxxxx --- drivers/i2c/busses/i2c-amd756-s4882.c | 2 +- drivers/i2c/busses/i2c-amd756.c | 2 ++ drivers/i2c/busses/i2c-amd756.h | 4 ++++ 3 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 drivers/i2c/busses/i2c-amd756.h diff --git a/drivers/i2c/busses/i2c-amd756-s4882.c b/drivers/i2c/busses/i2c-amd756-s4882.c index 063274388a75..741b9309d8b6 100644 --- a/drivers/i2c/busses/i2c-amd756-s4882.c +++ b/drivers/i2c/busses/i2c-amd756-s4882.c @@ -27,7 +27,7 @@ #include <linux/i2c.h> #include <linux/mutex.h> -extern struct i2c_adapter amd756_smbus; +#include "i2c-amd756.h" static struct i2c_adapter *s4882_adapter; static struct i2c_algorithm *s4882_algo; diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c index ef1307a258e9..86ee8d102d69 100644 --- a/drivers/i2c/busses/i2c-amd756.c +++ b/drivers/i2c/busses/i2c-amd756.c @@ -32,6 +32,8 @@ #include <linux/acpi.h> #include <linux/io.h> +#include "i2c-amd756.h" + /* AMD756 SMBus address offsets */ #define SMB_ADDR_OFFSET 0xE0 #define SMB_IOSIZE 16 diff --git a/drivers/i2c/busses/i2c-amd756.h b/drivers/i2c/busses/i2c-amd756.h new file mode 100644 index 000000000000..f3db35939b5c --- /dev/null +++ b/drivers/i2c/busses/i2c-amd756.h @@ -0,0 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* Copyright (c) 2019 Ben Dooks <ben.dooks@xxxxxxxxxxxxxxxx> */ + +extern struct i2c_adapter amd756_smbus; -- 2.24.0
