Hello, On Wed, Nov 27, 2019 at 07:12:09AM +0000, Peng Ma wrote: > EDMA may be not available or defered due to dependencies on > other modules, If these scenarios is encountered, we should > defer probing. I'd write: i2c: imx: Defer probing if requesting DMA yields EPROBE_DEFER DMA might not be available yet when the i2c device probes. Properly handle EPROBE_DEFER on dma channel allocation by passing on this error. It would be nice to point out where/how this failed for you. Other than that this looks reasonable. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
