On Thu, Nov 21, 2019 at 2:40 PM Guenter Roeck <groeck@xxxxxxxxxx> wrote: > > On Thu, Nov 21, 2019 at 1:11 PM Raul E Rangel <rrangel@xxxxxxxxxxxx> wrote: > > > > If the i2c-cros-ec-tunnel driver is compiled into the kernel, it is > > possible that i2c-cros-ec-tunnel could be probed before cros_ec_XXX > > has finished initializing and setting the drvdata. This would cause a > > NULL pointer panic. > > > > Converting this driver over to an MFD solves the problem and aligns with > > where the cros_ec is going. > > > > I thought the mfd maintainer objects to the use of the mfd API outside > drivers/mfd. Did that change recently ? The MFD apis are only used in drivers/mfd/cros_ec_dev.c. drivers/i2c/busses/i2c-cros-ec-tunnel.c just registers as a simple driver. Raul
