On Wed, 20 Nov 2019 17:19:32 +0200, Andy Shevchenko wrote: > There is no suffix applied to Intel Jasper Lake SOC. Remove it > from the comments and definitions. Besides that, it's a SOC, > thus replace PCH with SOC where it appropriate. > > Fixes: e0c61c04791a ("i2c: i801: Add support for Intel Jasper Lake") > Cc: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > v2: PCH -> SOC (Jarkko) > Documentation/i2c/busses/i2c-i801.rst | 2 +- > drivers/i2c/busses/Kconfig | 2 +- > drivers/i2c/busses/i2c-i801.c | 8 ++++---- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/i2c/busses/i2c-i801.rst b/Documentation/i2c/busses/i2c-i801.rst > index aa4a0e26e9b9..b83da0e94184 100644 > --- a/Documentation/i2c/busses/i2c-i801.rst > +++ b/Documentation/i2c/busses/i2c-i801.rst > @@ -42,7 +42,7 @@ Supported adapters: > * Intel Comet Lake (PCH) > * Intel Elkhart Lake (PCH) > * Intel Tiger Lake (PCH) > - * Intel Jasper Lake (PCH) > + * Intel Jasper Lake (SOC) > > Datasheets: Publicly available at the Intel website > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 45ca099e7315..71e5ee263dce 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -145,7 +145,7 @@ config I2C_I801 > Comet Lake (PCH) > Elkhart Lake (PCH) > Tiger Lake (PCH) > - Jasper Lake (PCH) > + Jasper Lake (SOC) > > This driver can also be built as a module. If so, the module > will be called i2c-i801. > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index df02040d36d5..f5e69fe56532 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -67,7 +67,7 @@ > * Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes > * Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes > * Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes > - * Jasper Lake-N (PCH) 0x4da3 32 hard yes yes yes > + * Jasper Lake (SOC) 0x4da3 32 hard yes yes yes > * > * Features supported by this driver: > * Software PEC no > @@ -226,7 +226,7 @@ > #define PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS 0x34a3 > #define PCI_DEVICE_ID_INTEL_5_3400_SERIES_SMBUS 0x3b30 > #define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23 > -#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_N_SMBUS 0x4da3 > +#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3 > #define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4 > #define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22 > #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_SMBUS 0x8ca2 > @@ -1076,7 +1076,7 @@ static const struct pci_device_id i801_ids[] = { > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS) }, > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS) }, > - { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_N_SMBUS) }, > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) }, > { 0, } > }; > > @@ -1759,7 +1759,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) > case PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS: > case PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS: > case PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS: > - case PCI_DEVICE_ID_INTEL_JASPER_LAKE_N_SMBUS: > + case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS: > priv->features |= FEATURE_BLOCK_PROC; > priv->features |= FEATURE_I2C_BLOCK_READ; > priv->features |= FEATURE_IRQ; Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> Thanks, -- Jean Delvare SUSE L3 Support