On Tue, Aug 13, 2019 at 01:55:54PM +0200, Sebastian Andrzej Siewior wrote:
> The drivers sets IRQF_ONESHOT and passes only a primary handler. The IRQ
> is masked while the primary is handler is invoked independently of
> IRQF_ONESHOT.
> With IRQF_ONESHOT the core code will not force-thread the interrupt and
> this is probably not intended. I *assume* that the original author copied
> the IRQ registration from another driver which passed a primary and
> secondary handler and removed the secondary handler but keeping the
> ONESHOT flag.
>
> Remove IRQF_ONESHOT.
>
> Reported-by: Benjamin Rouxel <benjamin.rouxel@xxxxxx>
> Tested-by: Benjamin Rouxel <benjamin.rouxel@xxxxxx>
> Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Krzysztof, are you okay with this change?
> ---
> drivers/i2c/busses/i2c-exynos5.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
> index e4e7932f78000..e7514c16b756c 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -791,9 +791,7 @@ static int exynos5_i2c_probe(struct platform_device *pdev)
> }
>
> ret = devm_request_irq(&pdev->dev, i2c->irq, exynos5_i2c_irq,
> - IRQF_NO_SUSPEND | IRQF_ONESHOT,
> - dev_name(&pdev->dev), i2c);
> -
> + IRQF_NO_SUSPEND, dev_name(&pdev->dev), i2c);
> if (ret != 0) {
> dev_err(&pdev->dev, "cannot request HS-I2C IRQ %d\n", i2c->irq);
> goto err_clk;
> --
> 2.23.0.rc1
>
Attachment:
signature.asc
Description: PGP signature
