On Tue, 2019-09-03 at 08:54 +0200, Bartosz Golaszewski wrote: > wt., 3 wrz 2019 o 08:10 Tomasz Figa <tfiga@xxxxxxxxxxxx> napisał(a): > > > > On Mon, Sep 2, 2019 at 5:11 PM Bartosz Golaszewski > > <bgolaszewski@xxxxxxxxxxxx> wrote: > > > > > > pon., 2 wrz 2019 o 09:42 Bibby Hsieh <bibby.hsieh@xxxxxxxxxxxx> napisał(a): > > > > > > > > On Mon, 2019-09-02 at 09:23 +0200, Bartosz Golaszewski wrote: > > > > > pon., 2 wrz 2019 o 05:32 Bibby Hsieh <bibby.hsieh@xxxxxxxxxxxx> napisał(a): > > > > > > > > > > > > Although in the most platforms, the power of eeprom and i2c > > > > > > are alway on, some platforms disable the eeprom and i2c power > > > > > > in order to meet low power request. > > > > > > This patch add the pm_runtime ops to control power to support > > > > > > all platforms. > > > > > > > > > > > > Changes since v1: > > > > > > - remove redundant code > > > > > > - fixup coding style > > > > > > > > > > > > > > > > The subject tag should be v2. Patches start at (implicit) version 1. > > > > > It's even more confusing since you're saying "Changes since v1" here > > > > > but the subject says v1 too. > > > > > > > > > Ok, I will fix up it and resent version 2. > > > > > > > > > > Please do it after v5.4-rc1 is tagged though. > > > > Thanks Bart for reviewing. > > > > By the way, I think we also need the DT bindings to be updated, right? > > Thanks, Tomasz :) > > Best regards, > > Tomasz > > Yes, definitely, thanks for pointing that out. > > Bibby: the DT updates should come in a separate patch and please Cc > the device-tree maintainers. Got it, I will add two optional properties (power-supply and i2c-supply) in DT. Bibby > > Bart