Re: [PATCH] i2c-eeprom_slave: Add support for more eeprom models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/2/19 12:22 PM, Wolfram Sang wrote:
various files has been tested and works fine. One new thing which could
happen now is that for a 16 bit address pointer, only 8 bit get sent
before a repeated start switches to reading data. This can be easily
simulated with the 'i2ctransfer' tool from i2c-utils.  TBH, I have no
idea how real EEPROMs react to this situation. Our driver currently uses
the pointer with only 8 bits fed and the upper 8 bits being 0. This
could be valid. Do you have a real EEPROM to check against?
Thinking more about it, I wouldn't bet all EERPOMs out there handle this
case the same way. So likely, our current handling might be good enough.


I have a real EEPROM that I can test against, and I can probably set up a quick test for that specific device only. But as you say, I have no idea if this is representative for all EEPROM or not.


I will try to get time to fix all your comments and send in a new patch later this week.


/BA





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux