On Thu, Aug 29, 2019 at 10:57:52PM +0200, Alexandre Belloni wrote: > On 20/08/2019 17:42:37+0200, Wolfram Sang wrote: > > I was about to simplify the call to i2c_unregister_device() when I > > realized that converting to devm_i2c_new_dummy_device() will simplify > > the driver a lot. So I took this approach. > > > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > --- > > Build tested only, buildbot is happy, too. > > > > Please apply to your tree. > > > > I'm confused because I already applied: > https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=7150710f3084de8d35ce3221eeae2caee8813f92 The above was a mass conversion to i2c_new_dummy_device() to make sure all in-kernel users use the API returning an ERRPTR. Mass conversion to the devm_ variant of the same function was too troublesome. With another series, I wanted to remove superfluous error checking of i2c_unregister_device() because it is NULL-ptr safe, like here: > > - if (info->rtc) > > - i2c_unregister_device(info->rtc); But for these two RTC drivers, I figured moving to devm_* is way easier than fixing up the mass conversion result from coccinelle.
Attachment:
signature.asc
Description: PGP signature
