On Mon, 19 Aug 2019 13:16:01 +0530, Nishka Dasgupta wrote:
> Static structure tsl2550_info, of type i2c_board_info, is referenced
> only twice: the first time in arguments to dev_info() (which does not
> modify it) and the second time as the last argument to function
> i2c_new_device() (where the corresponding parameter is declared as
> const). As tsl2550_info is therefore never modified, make it const to
> protect it from unintended modifications.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-taos-evm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
> index c82e78f57386..056df6b2538a 100644
> --- a/drivers/i2c/busses/i2c-taos-evm.c
> +++ b/drivers/i2c/busses/i2c-taos-evm.c
> @@ -39,7 +39,7 @@ struct taos_data {
> };
>
> /* TAOS TSL2550 EVM */
> -static struct i2c_board_info tsl2550_info = {
> +static const struct i2c_board_info tsl2550_info = {
> I2C_BOARD_INFO("tsl2550", 0x39),
> };
>
Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
Thanks,
--
Jean Delvare
SUSE L3 Support
