On Fri, 2019-08-23 at 16:13 +0800, Hsin-Yi Wang wrote: > On Fri, Aug 23, 2019 at 4:09 PM Qii Wang <qii.wang@xxxxxxxxxxxx> wrote: > > > > > > > static u32 mtk_i2c_functionality(struct i2c_adapter *adap) > > > { > > > - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > + if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN) > > > + return I2C_FUNC_I2C | > > > + (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > > > + else > > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > > It can be removed? > See previous discussion: https://patchwork.kernel.org/patch/10814391/#22484435 > but not all SoC's quirks has I2C_AQ_NO_ZERO_LEN. ok, it looks good for me, thanks. Reviewed-by: Qii Wang <qii.wang@xxxxxxxxxxxx>