Hi Krzysztof, > - Reduced the number of dev_dbg messages. Yes, that looks good. Just some curly braces left over... > + if (fifo_status & SLV_FIFO_STRC) { > + i2c_slave_event(idev->slave, > + I2C_SLAVE_WRITE_REQUESTED, &val); > + } ... > + if (fifo_status & SLV_FIFO_RSC) { > + readl(idev->base + SLV_DATA); /* dummy read */ > + } .. > + if (status & SLV_STATUS_SRC1) { > + i2c_slave_event(idev->slave, I2C_SLAVE_STOP, &val); > + } If you add '--strict' to checkpatch, it warns about two of them. Kind regards, Wolfram
Attachment:
signature.asc
Description: PGP signature