Re: [PATCH v6 18/57] i2c: Remove dev_err() usage after platform_get_irq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Wolfram Sang (2019-07-31 07:30:11)
> > -dev_err(...);
> 
> What about pr_err, ...?

Sure. I haven't tried to find these ones or pr_warn(), etc.

> 
> > While we're here, remove braces on if statements that only have one
> > statement (manually).
> 
> You can let cocci do this for you, too. From the top of my head:
> 
> if (...)
> - {
>  S
> - }
> 
> with S being a statement and this rule depending on the matching rule.
> 

Cool thanks for the tip! I'll have to try it out.





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux