Re: [PATCH] eeprom: at24: Limit gpio calls to when wp_gpio is defined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2019-07-08 at 10:26 +0200, Bartosz Golaszewski wrote:
> sob., 6 lip 2019 o 19:57 Claus H. Stovgaard <cst@xxxxxxxxxxxx>
> napisał(a):
> > 
> > 
> > On lør, 2019-07-06 at 19:33 +0200, Bartosz Golaszewski wrote:
> > > 
> > > Hi Claus,
> > > 
> > > gpiod_set_value_cansleep() doesn't complain if the passed
> > > descriptor
> > > is NULL - it just quietly returns. Could you give me some more
> > > info
> > > on
> > > how you trigger this warning?
> > > 
> > > Bart
> > Hi Bart
> > 
> > If you don't have enabled gpiolib, (E.g. CONFIG_GPIOLIB is not set)
> > gpiod_set_value_cansleep ends in /include/linux/gpio/consumer.h 
>
> Cc Linus Walleij
> 
> I see. This isn't a problem with at24 but with the GPIO API. I Cc'ed
> you on a patch I've just sent. Please take a look a possibly test.
> 
> Bart

Hi Bart

Have just looked at the patch and it look good to me.
Will test it, and answer on the separate patch mail, but think it will
work great for me.

Claus



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux