On 21.06.19 23:17, Wolfram Sang wrote: > On Mon, Jun 17, 2019 at 08:39:37PM +0200, Enrico Weigelt, metux IT consult wrote: >> From: Enrico Weigelt <info@xxxxxxxxx> >> >> Add more helper macros for trivial driver init cases, similar to the >> already existing module_i2c_driver()+friends - now for those which >> are initialized at other stages (eg. by subsys_initcall()). >> >> This helps to further reduce driver init boilerplate. > > Uh, no! Using subsys_initcall is an old fashioned hack to work around > boot time dependencies. Unless there are very strong arguments, I > usually do not accept them anymore. So, any simplification of that sends > out the wrong message. Okay, what's the correct initialization method then ? Just convert it to already existing module_i2c_driver() ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
