Re: [PATCH] decode-dimms: display MAC from DDR3 SPD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 14 Jun 2019 15:00:44 +0200, Wolfram Sang wrote:
> On Fri, Jun 14, 2019 at 02:58:14PM +0200, Francois Cartegnie wrote:
> > JEDEC Standard No. 21-C, Annex K, Release 6
> > 
> > Byte 41 is specified, the lower part containing
> > the MAC value, identical as DDR4.  
> 
> Adding Jean (the maintainer to CC)...

Thanks Wolfram.

> > ---
> >  eeprom/decode-dimms | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
> > index b976442..2c33f0b 100755
> > --- a/eeprom/decode-dimms
> > +++ b/eeprom/decode-dimms
> > @@ -1703,6 +1703,12 @@ sub decode_ddr3_sdram($)
> >  		tns3($bytes->[27] * $mtb));
> >  	printl("Minimum Four Activate Window Delay (tFAW)",
> >  		tns3(((($bytes->[28] & 15) << 8) + $bytes->[29]) * $mtb));
> > +# other information
> > +        my @mac = ("Untested",
> > +                   "700 K", "600 K", "500 K", "400 K", "300 K", "200 K",
> > +                   undef, "Unlimited");
> > +        my $mac = $bytes->[41] & 0x0f;
> > +        printl_cond(defined $mac[$mac], "Maximum Active Count (MAC)", $mac[$mac]);
> >  
> >  # miscellaneous stuff
> >  	prints("Optional Features");

Must be a recent addition, the latest version of the specification I
had did not mention it, I had to download an updated version from Jedec.

Looks good, patch applied, thanks. I changed "Active" to "Activate" as
I believe "Active" is a typo in the specification, and moved it to the
misc section as it isn't really a timing.

-- 
Jean Delvare
SUSE L3 Support



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux