Hi Alexander, On Mon, 17 Jun 2019 08:40:27 +0000, Sverdlin, Alexander (Nokia - DE/Ulm) wrote: > On 13/06/2019 11:13, Jean Delvare wrote: > >> Add SMBUS 2.0 Block Write-Block Read Process Call command support. > > I have never seen any SMBus device using this command. Which device do > > you need it for? > > That's our in-house FPGA design. This device is not otherwise publicly available. OK. > >> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> > >> --- > >> drivers/i2c/busses/i2c-i801.c | 43 +++++++++++++++++++++++++++++++++++++------ > >> 1 file changed, 37 insertions(+), 6 deletions(-) > >> (...) > > Looks good overall, except for missing an update to the documentation > > file (Documentation/i2c/busses/i2c-i801). However I will only consider > > applying the patch if it has a real use case. > > But the support for the new command is long-time tested and reported to work fine, > that's why I thought it can be of interest for the community. > > Please let me know if I should update the documentation and re-spin or this is > not of the maintainer's interest at all. It is of interest. I just wanted to make sure you had implemented it because the need exists and not just because the controller happens to support it. Now that this is clarified, I'll be happy to review and approve the patch, if you submit it again based on a recent code base and with the missing documentation update included. Thanks, -- Jean Delvare SUSE L3 Support
