On Thu, Jun 13, 2019 at 07:45:27PM +0300, Andy Shevchenko wrote:
> The commit
>
> 19b07cb4a187 ("i2c: i801: Register optional lis3lv02d I2C device on Dell machines")
>
> introduced a new check in order to enumerate some slave devices on Dell
> machines. Though, it brings a regression on machines where DMI vendor is not set.
>
> BUG: kernel NULL pointer dereference, address: 0000000000000000
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
> PGD 0 P4D 0
> Oops: 0000 [#1] SMP PTI
> CPU: 8 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc4-next-20190613+ #317
> RIP: 0010:strcmp+0xc/0x20
>
> To fix this crash, check if vendor field is present before accessing to it.
>
> Fixes: 19b07cb4a187 ("i2c: i801: Register optional lis3lv02d I2C device on Dell machines")
> Cc: Pali Rohár <pali.rohar@xxxxxxxxx>
> Cc: Jean Delvare <jdelvare@xxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Applied to for-next to fix the crash soonish, thanks!
For the other two patches, I'll give Jean a few more days to comment.
Attachment:
signature.asc
Description: PGP signature
