Re: [PATCH] i2c: iop: Use GPIO descriptors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 01, 2019 at 12:37:56AM +0200, Linus Walleij wrote:
> The IOP3xx has some elaborate code to directly slam the
> GPIO lines multiplexed with I2C down low before enablement,
> apparently a workaround for a hardware bug found in the
> early chips.
> 
> After consulting the developer documentation for IOP80321
> and IOP80331 I can clearly see that this may be useful for
> IOP80321 family (mach-iop32x) but it is highly dubious for
> any 80331 series or later chip: in these chips the lines
> are not multiplexed for UARTs.
> 
> We convert the code to pass optional GPIO descriptors
> and register these only on the 80321-based boards where
> it makes sense, optionally obtain them in the driver and
> use the gpiod_set_raw_value() to ascertain the line gets
> driven low when needed.
> 
> The GPIO driver does not give the GPIO chip a reasonable
> label so the patch also adds that so that these machine
> descriptor tables can be used.
> 
> Cc: arm@xxxxxxxxxx
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Added Dan's ack, too, and applied to for-next, thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux