Re: [PATCH v3 4/4] i2c: ocores: Add support for polling interrupt status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, February 8, 2019 2:19:05 PM CET Andrew Lunn wrote:
> On Fri, Feb 08, 2019 at 10:52:13AM +0100, Federico Vaga wrote:
> > Hi Andrew,
> > 
> > My patch for this (that is waiting since October 2018) has been reviewed
> > by
> > Peter at least once, and we agreed to make it ready for a
> > master_xfer_irq_less() proposal. In case that proposal evolves in an
> > actual
> > change, then the driver will be ready for it with minimal changes.
> 
> Hi Federico
> 
> Maybe it is me being impatient, i'm mostly a netdev maintainer, where
> things get reviewed in 3 days, not five months. However, it is now 5
> months later, and master_xfer_irq_less() has not happened. Is it
> really going to happen?

I do not know

> Are you making it happen? 

No

> Do we want to add a more invasive patch for something which might never 
> happen?

I do not understand why you say so. The differences are not that big, I may 
have wrote more code and more comments but I would not say that it is 
invasive.
 
> > If you have improvements or comments can you do it on the patch (V2) I
> > sent
> > 
> > https://patchwork.ozlabs.org/patch/990283/
> 
> In the end, i don't care if it is my patch or yours for polled IO. I
> would just like to see one of them merged in the next week or two
> before the next merge window opens. Please could you repost your patch
> series so we can review it.

I do not mind what get integrated, as you, I want to use a polling interface 
without compiling my own out-of-tree module.

I will re-send V3 for the entire patch set.

> 
>     Thanks
> 	Andrew







[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux