06.02.2019 22:16, Sowjanya Komatineni пишет: > + if (!i2c_dev->msg_read) { > + if (dma) { > + memcpy(buffer, msg->buf, msg->len); > + dma_sync_single_for_device(i2c_dev->dev, > + i2c_dev->dma_phys, > + xfer_size, > + DMA_TO_DEVICE); > + err = tegra_i2c_dma_submit(i2c_dev, xfer_size); > + if (err < 0) { > + dev_err(i2c_dev->dev, > + "starting TX DMA failed, err %d\n", > + err); > + goto unlock; > + } > + This newline is not really needed here. > + } else { > + tegra_i2c_fill_tx_fifo(i2c_dev); > + } > + } That's my last comment for v14. Looking forward for v15!